Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] NVCC warnings are errors #458

Merged
merged 3 commits into from
Nov 11, 2021
Merged

[FIX] NVCC warnings are errors #458

merged 3 commits into from
Nov 11, 2021

Conversation

trxcllnt
Copy link
Contributor

Make nvcc warnings into errors, fix new errors.

@trxcllnt trxcllnt requested a review from a team as a code owner October 20, 2021 21:13
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Oct 20, 2021
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Oct 20, 2021
@trxcllnt trxcllnt requested a review from a team as a code owner October 20, 2021 21:13
@harrism harrism requested a review from cwharris October 20, 2021 22:34
@harrism
Copy link
Member

harrism commented Oct 25, 2021

@gpucibot rerun tests

@trxcllnt trxcllnt added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 4, 2021
@trxcllnt
Copy link
Contributor Author

trxcllnt commented Nov 4, 2021

rerun tests

1 similar comment
@trxcllnt
Copy link
Contributor Author

rerun tests

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Nov 11, 2021
@trxcllnt
Copy link
Contributor Author

rerun tests

@trxcllnt
Copy link
Contributor Author

rerun tests

@trxcllnt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 04bb57c into rapidsai:branch-21.12 Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@harrism harrism harrism approved these changes

@thomcom thomcom thomcom approved these changes

@zhangjianting zhangjianting Awaiting requested review from zhangjianting zhangjianting is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @harrism @thomcom @cwharris