Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary_predicates.ipynb workflow and test data to package. #1258

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Add binary_predicates.ipynb workflow and test data to package. #1258

merged 7 commits into from
Oct 2, 2023

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Aug 10, 2023

Description

A missing package in this notebook is required in order for it to be usable with 23.08.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@thomcom thomcom self-assigned this Aug 10, 2023
@thomcom thomcom requested a review from a team as a code owner August 10, 2023 23:27
@thomcom thomcom requested review from trxcllnt and isVoid and removed request for a team August 10, 2023 23:27
@github-actions github-actions bot added the Python Related to Python code label Aug 10, 2023
isVoid
isVoid reviewed Aug 12, 2023
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the testing package included.

@harrism
Copy link
Member

harrism commented Aug 16, 2023

Targeting 23.10 now.

@thomcom thomcom changed the base branch from branch-23.08 to branch-23.10 August 17, 2023 19:57
@thomcom thomcom changed the title Enable binary_predicates.ipynb which doesn't work in 23.08 Enable binary_predicates.ipynb which doesn't work in 23.10 Aug 17, 2023
@thomcom thomcom added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 17, 2023
@thomcom thomcom requested review from harrism and removed request for trxcllnt August 17, 2023 19:58
@thomcom
Copy link
Contributor Author

thomcom commented Aug 17, 2023

Retargeted 23.10 and added the missing testing package.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 21, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@harrism
Copy link
Member

harrism commented Sep 25, 2023

/ok to test

@harrism
Copy link
Member

harrism commented Sep 28, 2023

Can you change the title of this PR so it doesn't sound like we are enabling something that doesn't work in this release?

@harrism
Copy link
Member

harrism commented Sep 28, 2023

/ok to test

@thomcom thomcom changed the title Enable binary_predicates.ipynb which doesn't work in 23.10 Add binary_predicates.ipynb workflow and test data to package. Sep 28, 2023
@thomcom
Copy link
Contributor Author

thomcom commented Sep 28, 2023

Thanks for shepherding this across the finish line, @harrism

harrism
harrism approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomcom !

@harrism
Copy link
Member

harrism commented Oct 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit 73e2df7 into rapidsai:branch-23.10 Oct 2, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid left review comments

@harrism harrism harrism approved these changes

Assignees

@thomcom thomcom

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomcom @harrism @isVoid