-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add segment Iterators, test multi*_range and miscellaneous lazy iterator additions #1026
Merged
rapids-bot
merged 21 commits into
rapidsai:branch-23.04
from
isVoid:feature/segment_iterators
Apr 5, 2023
Merged
Add segment Iterators, test multi*_range and miscellaneous lazy iterator additions #1026
rapids-bot
merged 21 commits into
rapidsai:branch-23.04
from
isVoid:feature/segment_iterators
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmake
Related to CMake code or build configuration
libcuspatial
Relates to the cuSpatial C++ library
labels
Mar 31, 2023
isVoid
changed the title
[skip-ci] Add Segment Iterators, Test Multi*_range and Miscllaneous addition to ranges
[skip-ci] Add Segment Iterators, Test Multi*_range and Miscllaneous lazy iterator additions
Mar 31, 2023
isVoid
commented
Mar 31, 2023
cpp/include/cuspatial/experimental/detail/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
isVoid
commented
Mar 31, 2023
cpp/include/cuspatial/experimental/detail/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
isVoid
commented
Apr 1, 2023
cpp/include/cuspatial/experimental/detail/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
isVoid
changed the title
[skip-ci] Add Segment Iterators, Test Multi*_range and Miscllaneous lazy iterator additions
Add Segment Iterators, Test Multi*_range and Miscllaneous lazy iterator additions
Apr 1, 2023
isVoid
added
feature request
New feature or request
non-breaking
Non-breaking change
labels
Apr 1, 2023
isVoid
commented
Apr 1, 2023
isVoid
commented
Apr 1, 2023
isVoid
commented
Apr 1, 2023
cpp/include/cuspatial/experimental/detail/ranges/multilinestring_range.cuh
Show resolved
Hide resolved
…al into feature/segment_iterators
3 tasks
harrism
changed the title
Add Segment Iterators, Test Multi*_range and Miscllaneous lazy iterator additions
Add segment Iterators, test multi*_range and miscellaneous lazy iterator additions
Apr 4, 2023
harrism
requested changes
Apr 4, 2023
cpp/include/cuspatial/experimental/ranges/multilinestring_range.cuh
Outdated
Show resolved
Hide resolved
trxcllnt
approved these changes
Apr 5, 2023
trxcllnt
reviewed
Apr 5, 2023
trxcllnt
reviewed
Apr 5, 2023
trxcllnt
reviewed
Apr 5, 2023
harrism
approved these changes
Apr 5, 2023
…al into feature/segment_iterators
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
This PR adds `linestring-polygon` distance API. This API divides up the work into two parts: point-in-polygon test and a load-balanced all-pairs segment-segment distance compute kernel. Closes #1027 Depends on #1026 Contributes to #757 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: #1011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
cmake
Related to CMake code or build configuration
feature request
New feature or request
libcuspatial
Relates to the cuSpatial C++ library
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1025
This PR adds RAI segment iterators to
multilinestring_range
andmultipolygon_range
.Caveats: this iterator currently will fail if the range contains empty geometries (such as an empty linestring or an empty polygon).
Usage example:
This PR also adds a few helper methods that will be used in
pairwise_linestring_polygon_distance
API. All of them are tested. Contributes to #991Checklist