Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Test notebooks in CI #954

Closed
harrism opened this issue Feb 23, 2023 · 2 comments · Fixed by #953
Closed

[FEA]: Test notebooks in CI #954

harrism opened this issue Feb 23, 2023 · 2 comments · Fixed by #953
Assignees
@harrism @isVoid
Labels
ci feature request New feature or request Python Related to Python code tests Relating to tests and test automation

Comments

@harrism
Copy link
Member

harrism commented Feb 23, 2023

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

We should test running our notebooks in CI. We have had situations where API changes have broken our notebooks. This would prevent that (at least for API syntax changes).

Describe any alternatives you have considered

No response

Additional context

Fixed by #953
@harrism harrism added feature request New feature or request Needs Triage Need team to review and classify labels Feb 23, 2023
@harrism harrism added tests Relating to tests and test automation Python Related to Python code ci and removed Needs Triage Need team to review and classify labels Feb 23, 2023
@harrism harrism moved this from Todo to In Progress in cuSpatial Feb 23, 2023
@thomcom
Copy link
Contributor

thomcom commented Feb 23, 2023

@taureandyernv has CI for notebooks set up in some other CI environment. I'm not sure if it is possible to run the notebooks CI as a part of our normal pass/fail process, ideas @taureandyernv ?

@thomcom
Copy link
Contributor

thomcom commented Feb 23, 2023

Ah looks like @isVoid already has a PR that does this?

@isVoid isVoid linked a pull request Feb 23, 2023 that will close this issue
Update Notebook with GeoSeries Usage and Add Notebook Tests #953
Merged
3 tasks
@rapids-bot rapids-bot bot closed this as completed in #953 Feb 24, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuSpatial Feb 24, 2023
@harrism harrism mentioned this issue Mar 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrism harrism

@isVoid isVoid

Labels
ci feature request New feature or request Python Related to Python code tests Relating to tests and test automation
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Notebook with GeoSeries Usage and Add Notebook Tests isVoid/cuspatial
3 participants
@thomcom @harrism @isVoid