Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Bug Discovered in linestring_intersection_intermediates.remove_if #946

Closed
isVoid opened this issue Feb 18, 2023 · 0 comments · Fixed by #945
Closed

[BUG]: Bug Discovered in linestring_intersection_intermediates.remove_if #946

isVoid opened this issue Feb 18, 2023 · 0 comments · Fixed by #945
Assignees
Labels
bug Something isn't working

Comments

@isVoid
Copy link
Contributor

isVoid commented Feb 18, 2023

Version

23.04

On which installation method(s) does this occur?

Rapids-Compose

Describe the issue

There are OB errors when running the LINESTRING_INTERSECTION_TEST_EXP with compute-sanitizer.

Minimum reproducible example

// Create a test case in `linestring_intersection_intermediates_remove_if_test.cu`:

TYPED_TEST(LinestringIntersectionIntermediatesRemoveIfTest, FourSegmentsKeep)
{
  using T       = TypeParam;
  using S       = segment<T>;
  using index_t = std::size_t;
  using flag_t  = uint8_t;

  auto intermediates =
    make_linestring_intersection_intermediates<index_t, S>({0, 0, 0, 1, 3, 4, 4, 4},
                                                           {S{{0.5, 0.5}, {1, 1}},
                                                            S{{0, 0}, {0.25, 0.25}},
                                                            S{{0.75, 0.75}, {1, 1}},
                                                            S{{0.75, 0.75}, {1, 1}}},
                                                           {0, 0, 0, 0},
                                                           {0, 0, 0, 0},
                                                           {0, 0, 0, 0},
                                                           {0, 0, 3, 2},
                                                           this->stream(),
                                                           this->mr());

  auto expected = make_linestring_intersection_intermediates<index_t, S>({0, 0, 0, 1, 3, 4, 4, 4},
                                                                         {S{{0.5, 0.5}, {1, 1}},
                                                                          S{{0, 0}, {0.25, 0.25}},
                                                                          S{{0.75, 0.75}, {1, 1}},
                                                                          S{{0.75, 0.75}, {1, 1}}},
                                                                         {0, 0, 0, 0},
                                                                         {0, 0, 0, 0},
                                                                         {0, 0, 0, 0},
                                                                         {0, 0, 3, 2},
                                                                         this->stream(),
                                                                         this->mr());

  CUSPATIAL_RUN_TEST(this->template run_single<flag_t>, intermediates, {0, 0, 0, 0}, expected);
}


// Run test with `compute-sanitizer`.

Relevant log output

No response

Environment details

No response

Other/Misc.

No response

@isVoid isVoid added bug Something isn't working Needs Triage Need team to review and classify labels Feb 18, 2023
@isVoid isVoid linked a pull request Feb 18, 2023 that will close this issue
3 tasks
@jarmak-nv jarmak-nv moved this from Todo to In Progress in cuSpatial Feb 21, 2023
@jarmak-nv jarmak-nv moved this from In Progress to Review in cuSpatial Feb 27, 2023
@rapids-bot rapids-bot bot closed this as completed in #945 Feb 27, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Feb 27, 2023
@jarmak-nv jarmak-nv removed the Needs Triage Need team to review and classify label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants