Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pairwise linestring distance should return one past the last written output iterator #576

Closed
isVoid opened this issue Jun 22, 2022 · 3 comments · Fixed by #670
Closed
Assignees
Labels
bug Something isn't working libcuspatial Relates to the cuSpatial C++ library
Milestone

Comments

@isVoid
Copy link
Contributor

isVoid commented Jun 22, 2022

According to development doc, to be consistent with std::transform API, the method should return the output iterator to one past the last element being written to by the algorithm. Currently, pairwise linestring distance returns void:

void pairwise_linestring_distance(OffsetIterator linestring1_offsets_first,

@isVoid isVoid added bug Something isn't working Needs Triage Need team to review and classify labels Jun 22, 2022
@isVoid isVoid changed the title [BUG] Pairwise linestring distance should return one past the last written output iterator. [BUG] Pairwise linestring distance should return one past the last written output iterator Jun 22, 2022
@harrism
Copy link
Member

harrism commented Jun 22, 2022

to be consistent with std::transform API, the method should return the output iterator to one past the last element being written to by the algorithm.

Not specifically transform, but to match the style of the STL and Thrust in general.

1 similar comment
@harrism
Copy link
Member

harrism commented Jun 22, 2022

to be consistent with std::transform API, the method should return the output iterator to one past the last element being written to by the algorithm.

Not specifically transform, but to match the style of the STL and Thrust in general.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@jarmak-nv jarmak-nv moved this to Todo in cuSpatial Aug 2, 2022
@harrism harrism added c++ and removed Needs Triage Need team to review and classify labels Aug 24, 2022
@harrism harrism added this to the ST_Distance milestone Aug 24, 2022
@rapids-bot rapids-bot bot closed this as completed in #670 Sep 19, 2022
rapids-bot bot pushed a commit that referenced this issue Sep 19, 2022
…670)

This PR updates `linestring_distance` to return past-the-end iterator to conform to other interfaces. Besides, this PR updates the assumption of `offset` arrays to be arrow compliant format (`N+1` instead of `N`).

closes #576

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: #670
Repository owner moved this from Todo to Done in cuSpatial Sep 19, 2022
@harrism harrism added libcuspatial Relates to the cuSpatial C++ library and removed c++ labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcuspatial Relates to the cuSpatial C++ library
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants