-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Pairwise linestring distance should return one past the last written output iterator #576
Comments
Not specifically |
1 similar comment
Not specifically |
This issue has been labeled |
…670) This PR updates `linestring_distance` to return past-the-end iterator to conform to other interfaces. Besides, this PR updates the assumption of `offset` arrays to be arrow compliant format (`N+1` instead of `N`). closes #576 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: #670
According to development doc, to be consistent with
std::transform
API, the method should return the output iterator to one past the last element being written to by the algorithm. Currently, pairwise linestring distance returnsvoid
:cuspatial/cpp/include/cuspatial/experimental/linestring_distance.cuh
Line 61 in dbebf67
The text was updated successfully, but these errors were encountered: