Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated binpred architecture (#1009)
The last couple of PRs were very brittle w.r.t updating their functionality. This PR eliminates some of that brittleness by adding object inheritance for every combination of features for every binary predicate. Class choice is handled by type dispatching on the input columns. The operation stack (`_preprocess`, `_op`, and `_postprocess`) is now chained to make debugging easier. Instead of calling the operations in sequence, they call one another. Refactoring the existing modules to use the new architecture was trivial. I'm still interested in modifying the architecture so that the set operations that determine the final result are identifiable, and possibly composable. Authors: - H. Thomson Comer (https://github.com/thomcom) Approvers: - Michael Wang (https://github.com/isVoid) - Mark Harris (https://github.com/harrism) URL: #1009
- Loading branch information