Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Group SVM model parameters by class #958

Open
tfeher opened this issue Aug 12, 2019 · 0 comments
Open

[FEA] Group SVM model parameters by class #958

tfeher opened this issue Aug 12, 2019 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@tfeher
Copy link
Contributor

tfeher commented Aug 12, 2019

Is your feature request related to a problem? Please describe.
Currently our SVM classifier does not follow the same layout as Sklearn / LibSVM while exposing the model parameters through the following attributes:

  • n_support_ we have total number of SVs while Sklearn has number per class
  • support_idx_ we store it in ascending order, while Sklearn has it sorted by class then ascending order by idx
  • support_ sorted as support_idx_
  • dual_coefs_ sorted as support_idx_

These differences have no effect on making predictions with SVM, but it is inconvenient if someone wants to explore the parameters of the fitted model.

Describe the solution you'd like
Make our SVM parameter layout compatible with Sklearn.

Additional context
The layout of the parameters becomes more complex once we have multi-class classification in place. This issue should probably be addressed when we implement multi-class classification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant