Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Rewrite HDBSCAN’s mutual_reachability_knn_l2 with RAFT primitives #4882

Open
cjnolet opened this issue Sep 2, 2022 · 1 comment
Open
Labels
? - Needs Triage Need team to review and classify feature request New feature or request inactive-30d

Comments

@cjnolet
Copy link
Member

cjnolet commented Sep 2, 2022

HDBSCAN contains some code which was adapted directly from the brute force nn code in FAISS to compute a knn directly in reachability space using an array of core distances.

One of the major goals we have had for some time is to remove the FAISS dependency from RAPIDS (specifically cuml and raft) as much as possible to simplify our list of dependencies.

The goal here is to rewrite the logic in mutial_reachabilty_knn_l2 on RAFT primitives so that it no longer requires FAISS. Given how optimized the k-selection code is in FAISS, we may end up ultimately bringing that over to RAFT directly (by copying it out of FAISS but giving proper attribution), but the remaining bits should all be fairly straightforward to port to RAFT directly.

Ideally this would be fixed by rapidsai/raft#798.

@cjnolet cjnolet added feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request inactive-30d
Projects
None yet
Development

No branches or pull requests

1 participant