Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Random Projection C++ unit test failure in CI #4627

Closed
dantegd opened this issue Mar 10, 2022 · 1 comment
Closed

[BUG] Random Projection C++ unit test failure in CI #4627

dantegd opened this issue Mar 10, 2022 · 1 comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@dantegd
Copy link
Member

dantegd commented Mar 10, 2022

Describe the bug
CI is currently blocked with failing RPRoj failures:

03:17:19 [ RUN      ] RPROJTestD2.EpsilonCheck
03:17:19 /workspace/.conda-bld/work/cpp/test/sg/rproj_test.cu:182: Failure
03:17:23 Value of: lower_bound <= pdist2 && pdist2 <= upper_bound
03:17:23   Actual: false
03:17:23 Expected: true
03:17:23 [  FAILED  ] RPROJTestD2.EpsilonCheck (3537 ms)

Seems to be related to the recent RNG change in RAFT: rapidsai/raft#513

@dantegd dantegd added bug Something isn't working ? - Needs Triage Need team to review and classify labels Mar 10, 2022
@vinaydes
Copy link
Contributor

This issue was caused because RAFT PR 513 changed the meaning of probability parameter for Bernoulli and Scaled Bernoulli distributions. Instead of passing probability of failure, the function now expects probability of success as parameter. So need to invert the probabilities at all the places.

PR #4628 should fix this issue.

@cjnolet cjnolet closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants