Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] -Werror causes FAISS build to fail #4318

Open
zbjornson opened this issue Oct 31, 2021 · 2 comments
Open

[BUG] -Werror causes FAISS build to fail #4318

zbjornson opened this issue Oct 31, 2021 · 2 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working inactive-30d inactive-90d

Comments

@zbjornson
Copy link
Contributor

zbjornson commented Oct 31, 2021

Describe the bug
Since #4075, at least one warning causes a from-source build to fail.

/home/zbbjornson/cuml/cpp/build/_deps/faiss-src/faiss/gpu/impl/DistanceUtils.cuh:291:27: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Werror=sign-compare]
  291 |     FAISS_ASSERT(grid.x * k == indices.getSize(1));
      |           ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

This also prevents cuML from building with CUDA 11.5 because some pragmas gained an nv_ prefix.

I'm surprised no one else has hit this yet. Is FAISS built separately and provided through Conda in RAPIDS's CI? I'd consider using -Werror only on cuML code and not on dependencies. https://stackoverflow.com/questions/62932366/compiling-library-with-different-flags-than-main-code shows how to do that.

Steps/Code to reproduce bug
Build from source without using Conda.

Expected behavior
Should build.

Environment details (please complete the following information):

  • Environment location: bare metal
  • Linux Distro/Architecture: Ubuntu 20.04.1
  • GPU Model/Driver: V100, 495.29.05
  • CUDA: 11.4
  • Method of cuDF & cuML install: from source (cmake 3.21.3, GCC 9.3.0) at 42303fb
@zbjornson zbjornson added ? - Needs Triage Need team to review and classify bug Something isn't working labels Oct 31, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working inactive-30d inactive-90d
Projects
None yet
Development

No branches or pull requests

1 participant