Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Replace calls to raft::allocate #4197

Closed
viclafargue opened this issue Sep 8, 2021 · 3 comments
Closed

[FEA] Replace calls to raft::allocate #4197

viclafargue opened this issue Sep 8, 2021 · 3 comments
Assignees
@viclafargue
Labels
CUDA/C++ feature request New feature or request inactive-30d inactive-90d Tech Debt Issues related to debt

Comments

@viclafargue
Copy link
Contributor

RAII allocation pattern usage is preferable to manual allocations and deallocations of GPU memory. Replacing calls to raft::allocate, that make use of the RMM allocator, with rmm::udevice_vector should guarantee that no memory leak ever happen.
@viclafargue viclafargue added feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 8, 2021
@viclafargue viclafargue mentioned this issue Sep 8, 2021
Closed
@viclafargue viclafargue added CUDA/C++ Tech Debt Issues related to debt and removed ? - Needs Triage Need team to review and classify labels Sep 15, 2021
@viclafargue viclafargue self-assigned this Sep 15, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@viclafargue
Copy link
Contributor Author

Finalized with #4526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viclafargue viclafargue

Labels
CUDA/C++ feature request New feature or request inactive-30d inactive-90d Tech Debt Issues related to debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viclafargue