Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] NearestNeighbors accepts col-major layout while KNeighborsClass/Reg require row-major #3153

Closed
cjnolet opened this issue Nov 18, 2020 · 0 comments
Closed

[BUG] NearestNeighbors accepts col-major layout while KNeighborsClass/Reg require row-major #3153

cjnolet opened this issue Nov 18, 2020 · 0 comments
Labels
bug Something isn't working CUDA / C++ CUDA issue Cython / Python Cython or Python issue

Comments

@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2020

Now that the knn primitive accepts col-major, I think we should be able to accept F-major in the kneighbors classifier/regressor. I think this might even work better for the multilabel y since each column is carved off during inference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CUDA / C++ CUDA issue Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjnolet