Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove direct imports from sklearn in non-pytest code #2467

Open
cjnolet opened this issue Jun 24, 2020 · 2 comments
Open

[BUG] Remove direct imports from sklearn in non-pytest code #2467

cjnolet opened this issue Jun 24, 2020 · 2 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@cjnolet
Copy link
Member

cjnolet commented Jun 24, 2020

There are a couple estimators that are importing sklearn directly and sklearn is not a direct dependency of cuML.

A very quick grep shows imports from sklearn in benchmarks, feature_extraction, preprocessing, & datasets.

We should consider mirroring very trivial imports, such as exceptions, in our codebase so that we don't have any dependencies on Scikit-learn outside of our pytests.

@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants