From f3be1b0240d7900c4012869b3637872014965f3c Mon Sep 17 00:00:00 2001 From: William Hicks Date: Thu, 11 Nov 2021 09:34:00 -0500 Subject: [PATCH 1/3] Mark Hellinger sparse test as xfail --- python/cuml/test/test_metrics.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/python/cuml/test/test_metrics.py b/python/cuml/test/test_metrics.py index 6d4ebf6813..4d954ba77a 100644 --- a/python/cuml/test/test_metrics.py +++ b/python/cuml/test/test_metrics.py @@ -1293,7 +1293,16 @@ def test_sparse_pairwise_distances_exceptions(): sparse_pairwise_distances(X, Y, metric="euclidean") -@pytest.mark.parametrize("metric", PAIRWISE_DISTANCE_SPARSE_METRICS.keys()) +@pytest.mark.parametrize( + "metric", [ + metric if metric != 'hellinger' + else pytest.param( + metric, + marks=pytest.mark.xfail("intermittent failure (Issue #4354)") + ) + for metric in PAIRWISE_DISTANCE_SPARSE_METRICS.keys() + ] +) @pytest.mark.parametrize("matrix_size,density", [ unit_param((1000, 100), 0.4), unit_param((20, 10000), 0.01), From 0a891f6429998375257df0377f39e7991ccc4069 Mon Sep 17 00:00:00 2001 From: William Hicks Date: Thu, 11 Nov 2021 12:00:58 -0500 Subject: [PATCH 2/3] Add missing keyword to xfail mark --- python/cuml/test/test_metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/cuml/test/test_metrics.py b/python/cuml/test/test_metrics.py index 4d954ba77a..377177a2f6 100644 --- a/python/cuml/test/test_metrics.py +++ b/python/cuml/test/test_metrics.py @@ -1298,7 +1298,7 @@ def test_sparse_pairwise_distances_exceptions(): metric if metric != 'hellinger' else pytest.param( metric, - marks=pytest.mark.xfail("intermittent failure (Issue #4354)") + marks=pytest.mark.xfail(reason="intermittent failure (Issue #4354)") ) for metric in PAIRWISE_DISTANCE_SPARSE_METRICS.keys() ] From 37c8e81d29d374ee61b5fa51ed2bab7a65115031 Mon Sep 17 00:00:00 2001 From: William Hicks Date: Thu, 11 Nov 2021 12:20:40 -0500 Subject: [PATCH 3/3] Fix style --- python/cuml/test/test_metrics.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/cuml/test/test_metrics.py b/python/cuml/test/test_metrics.py index 377177a2f6..e73aecc46b 100644 --- a/python/cuml/test/test_metrics.py +++ b/python/cuml/test/test_metrics.py @@ -1298,7 +1298,9 @@ def test_sparse_pairwise_distances_exceptions(): metric if metric != 'hellinger' else pytest.param( metric, - marks=pytest.mark.xfail(reason="intermittent failure (Issue #4354)") + marks=pytest.mark.xfail( + reason="intermittent failure (Issue #4354)" + ) ) for metric in PAIRWISE_DISTANCE_SPARSE_METRICS.keys() ]