Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable edge masking in the remaining primitives #4186

Merged
merged 59 commits into from
Mar 13, 2024

Conversation

seunghwak
Copy link
Contributor

This PR will update all the remaining primitives to support edge masking.

This PR pulls updates from #4126 and better be reviewed/merged after PR #4126.

@seunghwak seunghwak self-assigned this Feb 21, 2024
@seunghwak seunghwak added feature request New feature or request and removed cuGraph labels Feb 21, 2024
@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label Mar 9, 2024
@seunghwak seunghwak marked this pull request as ready for review March 9, 2024 00:44
@seunghwak seunghwak requested review from a team as code owners March 9, 2024 00:44
using Tests_MGPerVTransformReduceDstKeyAggregatedOutgoingE_Rmat =
Tests_MGPerVTransformReduceDstKeyAggregatedOutgoingE<cugraph::test::Rmat_Usecase>;

#if 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason these are skipped? Should we document that reason, eliminate the skipping, or eliminate the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, cugraph::kv_store_t does not compile with cuco mode and thrust tuple type value. I am planning to fix this in a separate PR but I will also add a FIXME here.

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 120e5b8 into rapidsai:branch-24.04 Mar 13, 2024
145 of 146 checks passed
@seunghwak seunghwak deleted the fea_more_prim_edge_masking branch May 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cuGraph feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants