-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Use RAFT error handling mechanism #951
Comments
So should we just use RAFT_EXPECTS/RAFT_FAIL until we have a use case for cugraph specific error macros? |
Let's also upgrade the RAFT git tag in the cmake to get the latest RAFT version that contains rapidsai/raft#15 |
And there are many redefined warnings (CUDA_TRY, CUDA_CHECK, THROW). They need to be deleted from cuGraph |
CUGRAPH_EXPECTS(FAIL) will throw cugraph::logic_error while RAFT_EXPECTS(FAIL) will throw raft::logic_error in addition to the difference in error message. And cuDF uses CUDF_EXPECTS (cuML currently uses ASSERT but I guess they will switch to CUML_EXPECTS) and I think we'd better use CUGRAPH_EXPECTS(FAIL) and use this for now. |
I assigned this to myself. This will be a quick fix. |
Describe the solution you'd like
RAFT error handling macros are updated (rapidsai/raft#15). We need to use this instead of redefining our own (our CUGRAPH_EXPECTS and CUGRAPH_FAIL need to be updated to use the RAFT mechanism).
The text was updated successfully, but these errors were encountered: