Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Add type-hints for missing modules added in cugraph_dgl package #2922

Closed
2 tasks done
Tracked by #3806
VibhuJawa opened this issue Nov 14, 2022 · 0 comments
Closed
2 tasks done
Tracked by #3806
Assignees
Labels
feature request New feature or request
Milestone

Comments

@VibhuJawa
Copy link
Member

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

In this PR #2896 we have some missing type hints for dgl.backend and DataFrame specific objects , we should look into a solution for adding those.

Describe your ideal solution

Every-user facing arg should have a type-hints and have everything tested with mypy or a similar type hint checker.

Describe any alternatives you have considered

No response

Additional context

CC: @rlratzel

Code of Conduct

  • I agree to follow cuGraph's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@VibhuJawa VibhuJawa added feature request New feature or request ? - Needs Triage Need team to review and classify labels Nov 14, 2022
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Nov 16, 2022
@alexbarghi-nv alexbarghi-nv self-assigned this Apr 16, 2024
@alexbarghi-nv alexbarghi-nv added this to the 24.08 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants