Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Need to evaluate how to extend C API testing #1923

Open
Tracked by #3336
rlratzel opened this issue Nov 2, 2021 · 0 comments
Open
Tracked by #3336

[ENH] Need to evaluate how to extend C API testing #1923

rlratzel opened this issue Nov 2, 2021 · 0 comments
Assignees
Labels
feature request New feature or request

Comments

@rlratzel
Copy link
Contributor

rlratzel commented Nov 2, 2021

From #1907 (comment) :

The C++ unit tests all use RAII constructs so that we don't leak resources and can run a series of tests within the same executable and see all of the failures in a single run of the test. Without RAII constructs we can leak resources (most important is GPU memory) and potentially introduce phantom failures later in the sequence of tests (e.g. tests that fail because they run out of memory, although they would succeed if the memory had been freed).

The C unit tests can't use RAII constructs. I think we need to explore the following ideas:

  • How extensively do we want to test the C API?
  • Do we want to be able to have multiple tests and see all of the failures?
  • How much effort do we want to go to in avoiding resource leaks in the tests when tests fail?

Based on the answers to these questions we can take some of these test cases and identify what macros we want to create that will make the unit tests easy to develop, read and maintain while satisfying the need.

@rlratzel rlratzel added the ? - Needs Triage Need team to review and classify label Nov 2, 2021
@rapidsai rapidsai deleted a comment from github-actions bot Sep 29, 2022
@rapidsai rapidsai deleted a comment from github-actions bot Sep 29, 2022
@BradReesWork BradReesWork added feature request New feature or request and removed ? - Needs Triage Need team to review and classify inactive-30d labels Sep 29, 2022
@BradReesWork BradReesWork added this to the 22.12 milestone Sep 29, 2022
@ChuckHastings ChuckHastings modified the milestones: 22.12, 23.02 Nov 28, 2022
@BradReesWork BradReesWork removed this from the 23.02 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants