Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support Bulk Feature Fetching in cuGraph-DGL/PyG #38

Closed
Tracked by #4350
alexbarghi-nv opened this issue Aug 28, 2024 · 1 comment
Closed
Tracked by #4350

[FEA] Support Bulk Feature Fetching in cuGraph-DGL/PyG #38

alexbarghi-nv opened this issue Aug 28, 2024 · 1 comment
Assignees
@alexbarghi-nv
Labels
feature request New feature or request

Comments

@alexbarghi-nv
Copy link
Member

We currently sample in bulk, but do not fetch features in bulk. This does not take full advantage of PCI-e bandwidth and, in some cases, the memory capacity of the GPU. This should be added as an option, and should possibly be the default means of feature fetching if performance is good enough.

Implementing this will require implementation of a new buffer that stores fetched features for a set of bulk samples.
@alexbarghi-nv alexbarghi-nv self-assigned this Aug 28, 2024
@alexbarghi-nv alexbarghi-nv added the feature request New feature or request label Aug 28, 2024
@alexbarghi-nv alexbarghi-nv mentioned this issue Aug 28, 2024
Open
@alexbarghi-nv
Copy link
Member Author

This no longer seems to be as relevant after the recent performance improvements in WholeGraph.

@alexbarghi-nv alexbarghi-nv closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexbarghi-nv