From 933f2fd91d7925ca46bfbee5b680099d487c33ab Mon Sep 17 00:00:00 2001 From: Yunsong Wang Date: Tue, 6 Jul 2021 13:21:05 -0400 Subject: [PATCH 1/3] Add ConfigureNVBench function to avoid concurrent main entry points --- cpp/benchmarks/CMakeLists.txt | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/cpp/benchmarks/CMakeLists.txt b/cpp/benchmarks/CMakeLists.txt index f8107d526c1..a2a78757fe0 100644 --- a/cpp/benchmarks/CMakeLists.txt +++ b/cpp/benchmarks/CMakeLists.txt @@ -29,7 +29,6 @@ target_link_libraries(cudf_datagen GTest::gmock_main GTest::gtest_main benchmark::benchmark - nvbench::main Threads::Threads cudf) @@ -56,6 +55,14 @@ function(ConfigureBench CMAKE_BENCH_NAME) PRIVATE cudf_benchmark_common cudf_datagen benchmark::benchmark_main) endfunction() +function(ConfigureNVBench CMAKE_BENCH_NAME) + add_executable(${CMAKE_BENCH_NAME} ${ARGN}) + set_target_properties(${CMAKE_BENCH_NAME} + PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$") + target_link_libraries(${CMAKE_BENCH_NAME} + PRIVATE cudf_benchmark_common cudf_datagen nvbench::main) +endfunction() + ################################################################################################### # - column benchmarks ----------------------------------------------------------------------------- ConfigureBench(COLUMN_CONCAT_BENCH column/concatenate_benchmark.cpp) From 7d8e788ab8f852d94a542058037c0a0f365beb73 Mon Sep 17 00:00:00 2001 From: Yunsong Wang Date: Wed, 7 Jul 2021 10:36:16 -0400 Subject: [PATCH 2/3] Update nvbench install directory --- cpp/benchmarks/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/benchmarks/CMakeLists.txt b/cpp/benchmarks/CMakeLists.txt index a2a78757fe0..d818fbe59ea 100644 --- a/cpp/benchmarks/CMakeLists.txt +++ b/cpp/benchmarks/CMakeLists.txt @@ -58,7 +58,7 @@ endfunction() function(ConfigureNVBench CMAKE_BENCH_NAME) add_executable(${CMAKE_BENCH_NAME} ${ARGN}) set_target_properties(${CMAKE_BENCH_NAME} - PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$") + PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$") target_link_libraries(${CMAKE_BENCH_NAME} PRIVATE cudf_benchmark_common cudf_datagen nvbench::main) endfunction() From e0d23b78de6b54e50133b01b567d850ba69a874d Mon Sep 17 00:00:00 2001 From: Yunsong Wang Date: Wed, 7 Jul 2021 11:23:09 -0400 Subject: [PATCH 3/3] Place all benchmarks in a new directory --- cpp/benchmarks/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/benchmarks/CMakeLists.txt b/cpp/benchmarks/CMakeLists.txt index d818fbe59ea..cf681a96cbd 100644 --- a/cpp/benchmarks/CMakeLists.txt +++ b/cpp/benchmarks/CMakeLists.txt @@ -50,7 +50,7 @@ target_link_libraries(cudf_benchmark_common PRIVATE cudf_datagen) function(ConfigureBench CMAKE_BENCH_NAME) add_executable(${CMAKE_BENCH_NAME} ${ARGN}) set_target_properties(${CMAKE_BENCH_NAME} - PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$") + PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$") target_link_libraries(${CMAKE_BENCH_NAME} PRIVATE cudf_benchmark_common cudf_datagen benchmark::benchmark_main) endfunction() @@ -58,7 +58,7 @@ endfunction() function(ConfigureNVBench CMAKE_BENCH_NAME) add_executable(${CMAKE_BENCH_NAME} ${ARGN}) set_target_properties(${CMAKE_BENCH_NAME} - PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$") + PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$") target_link_libraries(${CMAKE_BENCH_NAME} PRIVATE cudf_benchmark_common cudf_datagen nvbench::main) endfunction()