From e8485d9ed7fae2fd65366d088a847f00dec87107 Mon Sep 17 00:00:00 2001 From: seidl Date: Thu, 11 Apr 2024 22:48:27 +0000 Subject: [PATCH 1/2] fix arguments to lambda --- cpp/src/io/parquet/page_decode.cuh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/src/io/parquet/page_decode.cuh b/cpp/src/io/parquet/page_decode.cuh index fa1de5f301d..05a13ee7495 100644 --- a/cpp/src/io/parquet/page_decode.cuh +++ b/cpp/src/io/parquet/page_decode.cuh @@ -924,7 +924,7 @@ inline __device__ uint32_t InitLevelSection(page_state_s* s, auto start = cur; - auto init_rle = [s, lvl, end, level_bits](uint8_t const* cur, uint8_t const* end) { + auto init_rle = [s, lvl, level_bits](uint8_t const* cur, uint8_t const* end) { uint32_t const run = get_vlq32(cur, end); s->initial_rle_run[lvl] = run; if (!(run & 1)) { From ae6a3c01290b2f2b05d5be7ebdd53d231159d277 Mon Sep 17 00:00:00 2001 From: seidl Date: Thu, 11 Apr 2024 16:02:37 -0700 Subject: [PATCH 2/2] use optional::operator*() rather than value() since the latter is host only --- cpp/src/io/parquet/page_decode.cuh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/src/io/parquet/page_decode.cuh b/cpp/src/io/parquet/page_decode.cuh index 05a13ee7495..83bf7fb0d73 100644 --- a/cpp/src/io/parquet/page_decode.cuh +++ b/cpp/src/io/parquet/page_decode.cuh @@ -1160,7 +1160,7 @@ inline __device__ bool setupLocalPageInfo(page_state_s* const s, int32_t units = 0; // Duration types are not included because no scaling is done when reading if (s->col.logical_type.has_value()) { - auto const& lt = s->col.logical_type.value(); + auto const& lt = *s->col.logical_type; if (lt.is_timestamp_millis()) { units = cudf::timestamp_ms::period::den; } else if (lt.is_timestamp_micros()) { @@ -1217,7 +1217,7 @@ inline __device__ bool setupLocalPageInfo(page_state_s* const s, } else if (data_type == INT32) { // check for smaller bitwidths if (s->col.logical_type.has_value()) { - auto const& lt = s->col.logical_type.value(); + auto const& lt = *s->col.logical_type; if (lt.type == LogicalType::INTEGER) { s->dtype_len = lt.bit_width() / 8; } else if (lt.is_time_millis()) {