From e0774c8005c568f7b90f8f87c77963a73e20ddf7 Mon Sep 17 00:00:00 2001 From: Karthikeyan <6488848+karthikeyann@users.noreply.github.com> Date: Thu, 1 Feb 2024 18:54:37 +0530 Subject: [PATCH 1/2] [DOC] Update typo in docs example of structs_column_wrapper Replace struct_column_wrapper with structs_column_wrapper in example given in documentation of `structs_column_wrapper` --- cpp/include/cudf_test/column_wrapper.hpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpp/include/cudf_test/column_wrapper.hpp b/cpp/include/cudf_test/column_wrapper.hpp index c4fa4be0f89..fe3aa226213 100644 --- a/cpp/include/cudf_test/column_wrapper.hpp +++ b/cpp/include/cudf_test/column_wrapper.hpp @@ -1820,7 +1820,7 @@ class structs_column_wrapper : public detail::column_wrapper { * child_columns.push_back(std::move(child_int_col)); * child_columns.push_back(std::move(child_string_col)); * - * struct_column_wrapper struct_column_wrapper{ + * structs_column_wrapper struct_column_wrapper{ * child_cols, * {1,0,1,0,1} // Validity. * }; @@ -1846,7 +1846,7 @@ class structs_column_wrapper : public detail::column_wrapper { * fixed_width_column_wrapper child_int_col_wrapper{ 1, 2, 3, 4, 5 }; * string_column_wrapper child_string_col_wrapper {"All", "the", "leaves", "are", "brown"}; * - * struct_column_wrapper struct_column_wrapper{ + * structs_column_wrapper struct_column_wrapper{ * {child_int_col_wrapper, child_string_col_wrapper} * {1,0,1,0,1} // Validity. * }; @@ -1882,7 +1882,7 @@ class structs_column_wrapper : public detail::column_wrapper { * fixed_width_column_wrapper child_int_col_wrapper{ 1, 2, 3, 4, 5 }; * string_column_wrapper child_string_col_wrapper {"All", "the", "leaves", "are", "brown"}; * - * struct_column_wrapper struct_column_wrapper{ + * structs_column_wrapper struct_column_wrapper{ * {child_int_col_wrapper, child_string_col_wrapper} * cudf::detail::make_counting_transform_iterator(0, [](auto i){ return i%2; }) // Validity. * }; From e3fd77e5d69e445f78a6adc9b274aca8ec519a13 Mon Sep 17 00:00:00 2001 From: Karthikeyan <6488848+karthikeyann@users.noreply.github.com> Date: Thu, 1 Feb 2024 19:01:24 +0530 Subject: [PATCH 2/2] variable to structs_col --- cpp/include/cudf_test/column_wrapper.hpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cpp/include/cudf_test/column_wrapper.hpp b/cpp/include/cudf_test/column_wrapper.hpp index fe3aa226213..e7ca8400246 100644 --- a/cpp/include/cudf_test/column_wrapper.hpp +++ b/cpp/include/cudf_test/column_wrapper.hpp @@ -1820,12 +1820,12 @@ class structs_column_wrapper : public detail::column_wrapper { * child_columns.push_back(std::move(child_int_col)); * child_columns.push_back(std::move(child_string_col)); * - * structs_column_wrapper struct_column_wrapper{ + * structs_column_wrapper structs_col{ * child_cols, * {1,0,1,0,1} // Validity. * }; * - * auto struct_col {struct_column_wrapper.release()}; + * auto struct_col {structs_col.release()}; * @endcode * * @param child_columns The vector of pre-constructed child columns @@ -1846,12 +1846,12 @@ class structs_column_wrapper : public detail::column_wrapper { * fixed_width_column_wrapper child_int_col_wrapper{ 1, 2, 3, 4, 5 }; * string_column_wrapper child_string_col_wrapper {"All", "the", "leaves", "are", "brown"}; * - * structs_column_wrapper struct_column_wrapper{ + * structs_column_wrapper structs_col{ * {child_int_col_wrapper, child_string_col_wrapper} * {1,0,1,0,1} // Validity. * }; * - * auto struct_col {struct_column_wrapper.release()}; + * auto struct_col {structs_col.release()}; * @endcode * * @param child_column_wrappers The list of child column wrappers @@ -1882,12 +1882,12 @@ class structs_column_wrapper : public detail::column_wrapper { * fixed_width_column_wrapper child_int_col_wrapper{ 1, 2, 3, 4, 5 }; * string_column_wrapper child_string_col_wrapper {"All", "the", "leaves", "are", "brown"}; * - * structs_column_wrapper struct_column_wrapper{ + * structs_column_wrapper structs_col{ * {child_int_col_wrapper, child_string_col_wrapper} * cudf::detail::make_counting_transform_iterator(0, [](auto i){ return i%2; }) // Validity. * }; * - * auto struct_col {struct_column_wrapper.release()}; + * auto struct_col {structs_col.release()}; * @endcode * * @param child_column_wrappers The list of child column wrappers