From 869f38c684865e9cfed1c6515e9dea8c8534e7b9 Mon Sep 17 00:00:00 2001 From: David Wendt Date: Wed, 25 Jan 2023 14:57:53 -0500 Subject: [PATCH 1/4] Add comment about CUB patch for SegmentedSortInt.Bool gtest --- cpp/tests/sort/segmented_sort_tests.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpp/tests/sort/segmented_sort_tests.cpp b/cpp/tests/sort/segmented_sort_tests.cpp index 3156761243f..8432e3033b5 100644 --- a/cpp/tests/sort/segmented_sort_tests.cpp +++ b/cpp/tests/sort/segmented_sort_tests.cpp @@ -318,6 +318,8 @@ TEST_F(SegmentedSortInt, ErrorsMismatchArgSizes) CUDF_EXPECT_NO_THROW(cudf::stable_segmented_sort_by_key(input1, input1, segments)); } +// Test specifically verifies the patch added in https://github.com/rapidsai/cudf/pull/12234 +// This test will fail if CUB bug fix is not available or the patch has not been applied. TEST_F(SegmentedSortInt, Bool) { cudf::test::fixed_width_column_wrapper col1{ From b5d737d436eeeb9647c8f1df294a9519460f8c9e Mon Sep 17 00:00:00 2001 From: David Wendt Date: Wed, 25 Jan 2023 15:09:00 -0500 Subject: [PATCH 2/4] add missing article --- cpp/tests/sort/segmented_sort_tests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/tests/sort/segmented_sort_tests.cpp b/cpp/tests/sort/segmented_sort_tests.cpp index 8432e3033b5..37d99421794 100644 --- a/cpp/tests/sort/segmented_sort_tests.cpp +++ b/cpp/tests/sort/segmented_sort_tests.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2021-2022, NVIDIA CORPORATION. + * Copyright (c) 2021-2023, NVIDIA CORPORATION. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. From f5cd650038a668d2c7b9c044d844418500f1e027 Mon Sep 17 00:00:00 2001 From: David Wendt Date: Fri, 27 Jan 2023 09:06:24 -0500 Subject: [PATCH 3/4] fix wording --- cpp/tests/sort/segmented_sort_tests.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cpp/tests/sort/segmented_sort_tests.cpp b/cpp/tests/sort/segmented_sort_tests.cpp index 37d99421794..da9666cbc74 100644 --- a/cpp/tests/sort/segmented_sort_tests.cpp +++ b/cpp/tests/sort/segmented_sort_tests.cpp @@ -30,8 +30,7 @@ template using column_wrapper = cudf::test::fixed_width_column_wrapper; template -struct SegmentedSort : public cudf::test::BaseFixture { -}; +struct SegmentedSort : public cudf::test::BaseFixture {}; TYPED_TEST_SUITE(SegmentedSort, cudf::test::NumericTypes); using SegmentedSortInt = SegmentedSort; @@ -319,7 +318,7 @@ TEST_F(SegmentedSortInt, ErrorsMismatchArgSizes) } // Test specifically verifies the patch added in https://github.com/rapidsai/cudf/pull/12234 -// This test will fail if CUB bug fix is not available or the patch has not been applied. +// This test will fail if the CUB bug fix is not available or the patch has not been applied. TEST_F(SegmentedSortInt, Bool) { cudf::test::fixed_width_column_wrapper col1{ From b567655a176bb6ceb44c2288f9a5a21ba9b1ce07 Mon Sep 17 00:00:00 2001 From: David Wendt Date: Fri, 27 Jan 2023 09:07:08 -0500 Subject: [PATCH 4/4] fix format --- cpp/tests/sort/segmented_sort_tests.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpp/tests/sort/segmented_sort_tests.cpp b/cpp/tests/sort/segmented_sort_tests.cpp index da9666cbc74..0e7a2d0af87 100644 --- a/cpp/tests/sort/segmented_sort_tests.cpp +++ b/cpp/tests/sort/segmented_sort_tests.cpp @@ -30,7 +30,8 @@ template using column_wrapper = cudf::test::fixed_width_column_wrapper; template -struct SegmentedSort : public cudf::test::BaseFixture {}; +struct SegmentedSort : public cudf::test::BaseFixture { +}; TYPED_TEST_SUITE(SegmentedSort, cudf::test::NumericTypes); using SegmentedSortInt = SegmentedSort;