From dc9bfc05d41fbda0775d21b7a1b849849ac59882 Mon Sep 17 00:00:00 2001 From: vuule Date: Fri, 7 Oct 2022 16:06:38 -0700 Subject: [PATCH 1/2] remove warnings about structs in ORC --- cpp/include/cudf/io/orc.hpp | 6 ------ python/cudf/cudf/io/orc.py | 5 ----- python/cudf/cudf/tests/test_orc.py | 3 --- python/cudf/cudf/utils/ioutils.py | 11 ----------- 4 files changed, 25 deletions(-) diff --git a/cpp/include/cudf/io/orc.hpp b/cpp/include/cudf/io/orc.hpp index 7f3cb95e4b2..b1e2197a868 100644 --- a/cpp/include/cudf/io/orc.hpp +++ b/cpp/include/cudf/io/orc.hpp @@ -378,9 +378,6 @@ class orc_reader_options_builder { * auto result = cudf::io::read_orc(options); * @endcode * - * Note: Support for reading files with struct columns is currently experimental, the output may not - * be as reliable as reading for other datatypes. - * * @param options Settings for controlling reading behavior * @param mr Device memory resource used to allocate device memory of the table in the returned * table_with_metadata. @@ -783,9 +780,6 @@ class orc_writer_options_builder { * cudf::io::write_orc(options); * @endcode * - * Note: Support for writing tables with struct columns is currently experimental, the output may - * not be as reliable as writing for other datatypes. - * * @param options Settings for controlling reading behavior * @param mr Device memory resource to use for device memory allocation */ diff --git a/python/cudf/cudf/io/orc.py b/python/cudf/cudf/io/orc.py index 718b9c4144f..b9ce07466e5 100644 --- a/python/cudf/cudf/io/orc.py +++ b/python/cudf/cudf/io/orc.py @@ -418,11 +418,6 @@ def to_orc( """{docstring}""" for col in df._data.columns: - if isinstance(col, cudf.core.column.StructColumn): - warnings.warn( - "Support for writing tables with struct columns is " - "currently experimental." - ) if isinstance(col, cudf.core.column.CategoricalColumn): raise NotImplementedError( "Writing to ORC format is not yet supported with " diff --git a/python/cudf/cudf/tests/test_orc.py b/python/cudf/cudf/tests/test_orc.py index 422c2588eb0..5aa049db31a 100644 --- a/python/cudf/cudf/tests/test_orc.py +++ b/python/cudf/cudf/tests/test_orc.py @@ -1555,7 +1555,6 @@ def test_names_in_struct_dtype_nesting(datadir): assert edf.dtypes.equals(got.dtypes) -@pytest.mark.filterwarnings("ignore:.*struct.*experimental") def test_writer_lists_structs(list_struct_buff): df_in = cudf.read_orc(list_struct_buff) @@ -1567,7 +1566,6 @@ def test_writer_lists_structs(list_struct_buff): assert pyarrow_tbl.equals(df_in.to_arrow()) -@pytest.mark.filterwarnings("ignore:.*struct.*experimental") @pytest.mark.parametrize( "data", [ @@ -1668,7 +1666,6 @@ def test_empty_statistics(): assert stats[0]["i"].get("sum") == 1 -@pytest.mark.filterwarnings("ignore:.*struct.*experimental") @pytest.mark.parametrize( "equivalent_columns", [ diff --git a/python/cudf/cudf/utils/ioutils.py b/python/cudf/cudf/utils/ioutils.py index fe65b8f22fc..916a54e225a 100644 --- a/python/cudf/cudf/utils/ioutils.py +++ b/python/cudf/cudf/utils/ioutils.py @@ -299,12 +299,6 @@ Number of stripes List of column names -Notes ------ -Support for reading files with struct columns is currently experimental, -the output may not be as reliable as reading for other datatypes. -{remote_data_sources} - Examples -------- >>> import cudf @@ -447,11 +441,6 @@ Note that this option only affects columns of ListDtype. Names of other column types will be ignored. -Notes ------ -Support for writing tables with struct columns is currently experimental, -the output may not be as reliable as writing for other datatypes. - See Also -------- cudf.read_orc From 87fcb47790a63c4786236304154e3d291d87b94d Mon Sep 17 00:00:00 2001 From: vuule Date: Fri, 7 Oct 2022 17:07:28 -0700 Subject: [PATCH 2/2] remote sources restore --- python/cudf/cudf/utils/ioutils.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/python/cudf/cudf/utils/ioutils.py b/python/cudf/cudf/utils/ioutils.py index 916a54e225a..49e09cb40e3 100644 --- a/python/cudf/cudf/utils/ioutils.py +++ b/python/cudf/cudf/utils/ioutils.py @@ -299,6 +299,10 @@ Number of stripes List of column names +Notes +----- +{remote_data_sources} + Examples -------- >>> import cudf