From 93b964206a0198beefef30fc71ac13b4caa5441d Mon Sep 17 00:00:00 2001 From: David Wendt Date: Mon, 2 May 2022 09:25:55 -0400 Subject: [PATCH 1/2] Mention 2 cpp-reviewer requirement in pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2c5ecf68690..a8d78648bc9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -47,6 +47,10 @@ Here are some guidelines to help the review process go smoothly. If conflicts occur against the target branch they should be resolved by merging the target branch into the branch used for making the pull request. +8. Pull requests that modify cpp source that are marked ready for review + will automatically be assign two cudf-cpp-codeowners reviewers. + Ensure at least two approvals from cudf-cpp-codeowners before merging. + Many thanks in advance for your cooperation! --> From c9f5493f014dbca92cd93655171c2077727861e7 Mon Sep 17 00:00:00 2001 From: David Wendt Date: Tue, 3 May 2022 07:37:58 -0400 Subject: [PATCH 2/2] fix misspelling --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a8d78648bc9..8dac8083f31 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -48,7 +48,7 @@ Here are some guidelines to help the review process go smoothly. merging the target branch into the branch used for making the pull request. 8. Pull requests that modify cpp source that are marked ready for review - will automatically be assign two cudf-cpp-codeowners reviewers. + will automatically be assigned two cudf-cpp-codeowners reviewers. Ensure at least two approvals from cudf-cpp-codeowners before merging. Many thanks in advance for your cooperation!