Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QST] About ORC writer #9319

Closed
firestarman opened this issue Sep 28, 2021 · 4 comments
Closed

[QST] About ORC writer #9319

firestarman opened this issue Sep 28, 2021 · 4 comments
Assignees
Labels
cuIO cuIO issue question Further information is requested

Comments

@firestarman
Copy link
Contributor

What is your question?
What's the difference between cudf_io::write_orc and cudf_io::orc_chunked_writer ?
Do they both support decimal columns now ?

I saw this PR #8198 has added the decimal writing but seems only for the cudf_io::write_orc. Is it true?
If yes, any plan to let cudf_io::orc_chunked_writer also support decimals ?

Thanks in advance

@firestarman firestarman added question Further information is requested Needs Triage Need team to review and classify labels Sep 28, 2021
@beckernick beckernick added cuIO cuIO issue and removed Needs Triage Need team to review and classify labels Oct 5, 2021
@vuule vuule self-assigned this Oct 19, 2021
@vuule
Copy link
Contributor

vuule commented Oct 19, 2021

The only difference between write_orc and the chunk writer should be in the statistics - file-level statistics are excluded from chunked writes.

Decimal columns are supported by both APIs.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@vuule
Copy link
Contributor

vuule commented Nov 18, 2021

@firestarman did I answer your question, can we close the issue?

@vuule
Copy link
Contributor

vuule commented Dec 7, 2021

Closing as inactive. Please reopen if needed.

@vuule vuule closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuIO cuIO issue question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants