Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] support rank and dense_rank for nested structs #8959

Closed
revans2 opened this issue Aug 4, 2021 · 0 comments · Fixed by #8962
Closed

[FEA] support rank and dense_rank for nested structs #8959

revans2 opened this issue Aug 4, 2021 · 0 comments · Fixed by #8962
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@revans2
Copy link
Contributor

revans2 commented Aug 4, 2021

Is your feature request related to a problem? Please describe.
We are trying to push the Spark plugin to support as much of structs as possible. It would be nice to have rank and dense_rank support nested structs as input columns. This does not include lists as child columns under the structs.

Describe the solution you'd like
I don't know the best way to do this, but I suspect that the flatten method could be used with relatively small modifications to make this work.

Describe alternatives you've considered
Do the flatten ourselves, but it feels like it would be better for cudf to do it, especially if in the future we support other algorithms that do support lists or there are better, more optimized algorithms besides flatten.

Additional context
I know that @rwlee has been looking into this at least a little

@revans2 revans2 added feature request New feature or request Needs Triage Need team to review and classify labels Aug 4, 2021
@revans2 revans2 linked a pull request Aug 5, 2021 that will close this issue
@rwlee rwlee self-assigned this Aug 5, 2021
@beckernick beckernick added libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS and removed Needs Triage Need team to review and classify labels Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants