-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Support groupby collect agg on struct columns #8520
Comments
I thought this is already supported: In [3]: df = cudf.DataFrame(
...: {
...: 'a':['aa','aa','cc'],
...: 'd':[{"b": '1', "c": "one"}, {"b": '2', "c": "two"}, {"b": '3', "c": "one"}]
...: }
...: )
In [4]: df.groupby('a').collect()
...:
Out[4]:
d
a
aa [{'0': '1', '1': 'one'}, {'0': '2', '1': 'two'}]
cc [{'0': '3', '1': 'one'}] |
Are you ok if we close ? |
It sounds like this was disallowed because it was erroneously going down a codepath meant for string aggregations (and thus potentially brittle when used with structs/lists). @ayushdg is the expectation that these operations would behave as before, but by going down a well-tested codepath? |
Yup, that's the expectation. |
cc: @vyasr (just FYI), as I think we disabled these aggs on struct columns on one of your groupby cleanup PRs |
Perhaps you're thinking of these changes on #7731? Prior to this, there were a number of dtypes for which unsupported aggregations weren't being checked. |
This issue has been labeled |
Is your feature request related to a problem? Please describe.
Ability to create a list of struct columns using the
collect
agg via groupbyDescribe the solution you'd like
Describe alternatives you've considered
N/A
Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.
The text was updated successfully, but these errors were encountered: