You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
I believe we should match pandas here. Since the behavior we expose here is the behavior of libcudf, we might have to run a few extra kernels to explicitly solve this case.
I believe this is worth doing. It's a tradeoff between extra work that we need to do on the GPU which of course will impact performance, vs the possibility of users running the same data through the same sequence of mathematical operations between pandas and cuDF and getting a different number. IMO the second possibility is more likely to lead to issues on the user side than the first.
Environment overview (please complete the following information)
Environment location: Bare Metal
Method of cuDF install: Source
Environment details
Please run and paste the output of the cudf/print_env.sh script here, to gather any other relevant environment details
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.
This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.
Describe the bug
In pandas,
1**<NA> == 1
, whereas in cuDF,1**<NA> == <NA>
. Furthermore, in pandas,<NA> ** 0 == 1
whereas in cuDF,<NA> ** 0 == <NA>
.Steps/Code to reproduce bug
First issue:
Expected behavior
I believe we should match pandas here. Since the behavior we expose here is the behavior of libcudf, we might have to run a few extra kernels to explicitly solve this case.
I believe this is worth doing. It's a tradeoff between extra work that we need to do on the GPU which of course will impact performance, vs the possibility of users running the same data through the same sequence of mathematical operations between pandas and cuDF and getting a different number. IMO the second possibility is more likely to lead to issues on the user side than the first.
Environment overview (please complete the following information)
Environment details
Please run and paste the output of the
cudf/print_env.sh
script here, to gather any other relevant environment detailsAdditional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: