Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Python bindings for lists::contains #7462

Closed
shwina opened this issue Feb 26, 2021 · 1 comment · Fixed by #7547
Closed

[FEA] Python bindings for lists::contains #7462

shwina opened this issue Feb 26, 2021 · 1 comment · Fixed by #7547
Assignees
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@shwina
Copy link
Contributor

shwina commented Feb 26, 2021

#7039 introduces a lists::contains API that we should plumb through to Python. The Python API we want is probably something like:

>>> s = cudf.Series([[1, 2, 3], [3, 4, 5], [4, 5, 6]])
>>> s.list.contains(4)  # returns Series([False, True, True])
@shwina shwina added feature request New feature or request Needs Triage Need team to review and classify labels Feb 26, 2021
@skirui-source skirui-source self-assigned this Feb 26, 2021
@shwina shwina added Python Affects Python cuDF API. Cython and removed Needs Triage Need team to review and classify labels Feb 27, 2021
@kkraus14 kkraus14 reopened this Mar 23, 2021
@kkraus14
Copy link
Collaborator

@skirui-source please do not close issues until the pull request is merged. Generally using the fixes keyword is the preferred way of having pill requests automatically close issues: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

@skirui-source skirui-source linked a pull request Mar 25, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants