Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] rolling_window() does not support struct_view for most operations #7188

Open
mythrocks opened this issue Jan 22, 2021 · 3 comments
Open

[FEA] rolling_window() does not support struct_view for most operations #7188

mythrocks opened this issue Jan 22, 2021 · 3 comments
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@mythrocks
Copy link
Contributor

It appears that all the *rolling_window() functions do not currently support any aggregations on struct_view columns. There is no case in is_rolling_supported() that handles struct_view.

In the ideal case, we should support COUNT_VALID, COUNT_ALL, ROW_NUMBER, LEAD, LAG, and (soon) COLLECT on struct_view.

(COLLECT support should be added when #7133 is addressed.)
@mythrocks mythrocks added bug Something isn't working Needs Triage Need team to review and classify labels Jan 22, 2021
@harrism
Copy link
Member

harrism commented Jan 25, 2021

This seems like a feature request, not a bug report?

@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Jan 27, 2021
@kkraus14 kkraus14 changed the title [BUG] rolling_window() does not support struct_view for most operations [FEA] rolling_window() does not support struct_view for most operations Jan 27, 2021
@kkraus14 kkraus14 added feature request New feature or request and removed bug Something isn't working labels Jan 27, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@harrism @vyasr @kkraus14 @mythrocks @GregoryKimball