CompactProtocolWriter and ProtobufWriter API provide no encapsulation of the output buffer

[vuule]

Problem:
The protocol writer classes take a pointer to a vector and use it as the output buffer. Writes change the size of this vector. This vector is also modified (including size changes) outside of the writers. The ORC/Parquet writers have a std::vector data member that is reused for protocol writes and manually reset between uses. ORC writer also reuses the ProtobufWriter object. In addition, Parquet writer reuses the output buffer to output data unrelated to CompactProtocolWriter. All this makes the use error-prone.

Solution proposal:
Modify the protocol writer API to use an internal output buffer and only provide getters for it. Also, protocol writer objects should not be reused (and cannot, with the proposed API). There shouldn't be a buffer data member in xyz::writer::impl.
These changes would limit the scope of the state to functions instead of the lifetime of xyz::writer::impl objects.

[github-actions]

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

[vuule]

Issue still relevant.

[github-actions]

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.