-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avro reader has very limited test coverage #6802
Comments
Marking as P0 for 0.18 as it's preventing other Avro refactoring work. |
Maybe we can use Apache's python-based reader/writer to generate test data. Generating files via python from the c++ side seems backwards, though. Do we have a methodology to store/load pre-generated test data/files in tests? |
Maybe I'm misunderstanding the question, but you can generate tmp avro files using fastavro in Python tests. There are tests that already do this. |
It would be nice to have c++ tests, though, since the reader is implemented at that level. |
This issue has been labeled |
missing large tests still relevant |
Closing, since #12912 added larger tests |
Avro reader currently has a single test, with a few more basic tests pending to be merged.
Some cases not covered:
The text was updated successfully, but these errors were encountered: