Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Split Jitify stringification into a Separate CMake File #5749

Closed
codereport opened this issue Jul 23, 2020 · 1 comment
Closed

[FEA] Split Jitify stringification into a Separate CMake File #5749

codereport opened this issue Jul 23, 2020 · 1 comment
Labels
CMake CMake build issue feature request New feature or request good first issue Good for newcomers

Comments

@codereport
Copy link
Contributor

As @harrism mentioned in this comment #5704 (comment), the "stringification" of files for Jitify is growing to be quite large. This issue is to request that we refactor this into a function and put it in a separate CMake file.
@codereport codereport added feature request New feature or request Needs Triage Need team to review and classify labels Jul 23, 2020
@codereport codereport mentioned this issue Jul 23, 2020
Merged
4 tasks
@harrism harrism added CMake CMake build issue good first issue Good for newcomers and removed Needs Triage Need team to review and classify labels Jul 24, 2020
@robertmaynard robertmaynard mentioned this issue Feb 5, 2021
Merged
@robertmaynard
Copy link
Contributor

Closing as #7107 has been merged.

@harrism harrism closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CMake CMake build issue feature request New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robertmaynard @harrism @codereport