Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Use size_type in place of scalar in cudf::repeat. #5355

Closed
bdice opened this issue Jun 1, 2020 · 1 comment · Fixed by #5356
Closed

[FEA] Use size_type in place of scalar in cudf::repeat. #5355

bdice opened this issue Jun 1, 2020 · 1 comment · Fixed by #5356
Assignees
Labels
2 - In Progress Currently a work in progress feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@bdice
Copy link
Contributor

bdice commented Jun 1, 2020

Is your feature request related to a problem? Please describe.
Currently, cudf::tile accepts a size_type for the number of tilings, but cudf::repeat accepts a scalar const & for the number of repeats. The use of scalar seems unusual for something that has to be an unsigned integral quantity.

Describe the solution you'd like
Change API to accept size_type. Other similar APIs should be changed, too.

Additional context
@devavret @jrhemstad @davidwendt agreed with this idea.

@bdice bdice added feature request New feature or request 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. labels Jun 1, 2020
@bdice bdice self-assigned this Jun 1, 2020
@bdice
Copy link
Contributor Author

bdice commented Jun 1, 2020

I searched for instances of scalar in the code base and cudf::repeat was the only instance that I think should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant