Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add duration column types #5272

Closed
15 tasks done
harrism opened this issue May 25, 2020 · 6 comments
Closed
15 tasks done

[FEA] Add duration column types #5272

harrism opened this issue May 25, 2020 · 6 comments
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@harrism
Copy link
Member

harrism commented May 25, 2020

Is your feature request related to a problem? Please describe.
To support arithmetic on timestamps, we need duration types.
We need to support difference between every resolution of timestamp i.e. days, seconds, milliseconds, microseconds and nanoseconds.

Describe the solution you'd like
It should be based on std::chrono::duration in libcu++.

See also #4074

@harrism harrism added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. labels May 25, 2020
@devavret
Copy link
Contributor

It's possible I missed a discussion regarding this.

But, just to clarify, does this need one duration type or multiple? (duration_s, duration_ms, duration_ms, duration_ns). Asking because duration_ns would be required to support differences involving timestamp_ns but wouldn't be able to represent the full range of differences between two timestamp_s.

@jrhemstad
Copy link
Contributor

jrhemstad commented May 26, 2020

does this need one duration type or multiple?

Unfortunately, multiple. I believe we need a duration type for every resolution of timestamp.

@devavret
Copy link
Contributor

does this need one duration type or multiple?

Unfortunately, multiple. I believe we need a duration type for every resolution of timestamp.

Ok, I'll reword the issue

@kkraus14
Copy link
Collaborator

Bumping this to 0.16 as the cuIO piece will not land in 0.15.

@karthikeyann
Copy link
Contributor

parquet support for duration (#5903) is already done. ORC does not support duration (INTERVAL) type.
duration support for JSON and CSV only is pending in cuIO.

@karthikeyann
Copy link
Contributor

karthikeyann commented Sep 21, 2020

All features for duration type are complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

No branches or pull requests

6 participants