Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Investigate if release_assert impacts performance #3044

Closed
jrhemstad opened this issue Oct 10, 2019 · 3 comments
Closed

[FEA] Investigate if release_assert impacts performance #3044

jrhemstad opened this issue Oct 10, 2019 · 3 comments
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue

Comments

@jrhemstad
Copy link
Contributor

Is your feature request related to a problem? Please describe.
release_assert is used throughout libcudf code to signal an error in device code.

Most concerning is that this is used in type_dispatcher error path.

It's come to my attention that using the __assertfail may incur syscalls, which can force ABI constraints that result in a performance impact even in the happy path.

Describe the solution you'd like

We should benchmark with and without the release_assert in the type dispatcher (using the type dispatcher benchmark to start) and see if there is any difference in performance.

@jrhemstad jrhemstad added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue labels Oct 10, 2019
@jrhemstad
Copy link
Contributor Author

#7583

Turns out, it does! Kind of. It has a pretty sizable impact on binary size and compile time. Actual runtime performance impact seemed more minimal.

@harrism
Copy link
Member

harrism commented Mar 30, 2021

Should we close this now?

@jrhemstad
Copy link
Contributor Author

Yeah, I think it's fine to close this now given that #7583 made it so the assert is no longer present in Release code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue
Projects
None yet
Development

No branches or pull requests

2 participants