Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] upper_bound and lower_bound functions incorrect results when searching GDF_STRING_CATEGORY values #2790

Closed
jeanp413 opened this issue Sep 12, 2019 · 2 comments
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@jeanp413
Copy link
Contributor

Describe the bug
upper_bound and lower_bound functions give incorrect results when searching GDF_STRING_CATEGORY values

This is caused because the column's categories are not synced before doing the search

Steps/Code to reproduce bug
Call upper_bound / lower_bound with the cudf::table table and cudf::table values parameters containing a columns whose types are GDF_STRING_CATEGORY

Expected behavior
upper_bound and lower_bound should give correct results when searching GDF_STRING_CATEGORY values

@jeanp413 jeanp413 added Needs Triage Need team to review and classify bug Something isn't working labels Sep 12, 2019
@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Sep 20, 2019
@sameerz sameerz added the Spark Functionality that helps Spark RAPIDS label Oct 14, 2019
@kuhushukla
Copy link
Contributor

Based on some java side tests GDF_STRING also seems to be broken for lower/upper bound.

@harrism
Copy link
Member

harrism commented Dec 19, 2019

This is fixed in the libcudf++ API by #3229

@kuhushukla @jeanp413 please reopen if you find this is not the case.

@harrism harrism closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

No branches or pull requests

5 participants