Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check performance of changing default hasher to XXHash32 #17532

Closed
bdice opened this issue Dec 5, 2024 · 1 comment
Closed

Check performance of changing default hasher to XXHash32 #17532

bdice opened this issue Dec 5, 2024 · 1 comment

Comments

@bdice
Copy link
Contributor

bdice commented Dec 5, 2024

I would like to know if switching our default hasher from MurmurHash3_32 to XXHash32 has an impact on performance. This was previously proposed in #12829 but deserves an issue of its own to be acted upon.

If the register usage is lower for XXHash32 than MurmurHash3_32, it might benefit some of cudf's most complex kernels. Mixed joins, for instance, combine hashing and AST execution. Similar ideas have been mentioned before in issues like #10587. I'm not confident that this would make a positive difference (I expect no significant effect, based on our past explorations of mixed joins), but it would be worth checking.

Originally posted by @bdice in #12829

@bdice
Copy link
Contributor Author

bdice commented Dec 5, 2024

Closing as duplicate of #17531. Great minds ...open duplicate issues!

@bdice bdice closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant