Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Remove superfluous use of std::vector for std::future #16888

Closed
kingcrimsontianyu opened this issue Sep 24, 2024 · 0 comments · Fixed by #16829
Closed

[FEA] Remove superfluous use of std::vector for std::future #16888

kingcrimsontianyu opened this issue Sep 24, 2024 · 0 comments · Fixed by #16829
Assignees
@kingcrimsontianyu
Labels
feature request New feature or request

Comments

@kingcrimsontianyu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
std::vector<std::future> used here is unnecessary since the vector only contains a single element. The use of vector should be removed.

Describe the solution you'd like
Remove the vector.

Describe alternatives you've considered
N/A.

Additional context
N/A.
@kingcrimsontianyu kingcrimsontianyu added the feature request New feature or request label Sep 24, 2024
@kingcrimsontianyu kingcrimsontianyu self-assigned this Sep 24, 2024
@kingcrimsontianyu kingcrimsontianyu mentioned this issue Sep 24, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Sep 27, 2024
@kingcrimsontianyu
Remove superfluous use of std::vector for std::future (#16829)
4018d31 
This PR addresses #16888 , where a superfluous use of `std::vector` should be removed.

closes #16888

Authors:
  - Tianyu Liu (https://github.com/kingcrimsontianyu)
  - Vukasin Milovanovic (https://github.com/vuule)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #16829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingcrimsontianyu kingcrimsontianyu

Labels
feature request New feature or request
Projects
libcudf
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove superfluous use of std::vector for std::future kingcrimsontianyu/cudf
1 participant
@kingcrimsontianyu