Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Consider supporting extract_datetime_component in libcudf #16735

Closed
brandon-b-miller opened this issue Sep 4, 2024 · 2 comments · Fixed by #16776
Closed

[FEA] Consider supporting extract_datetime_component in libcudf #16735

brandon-b-miller opened this issue Sep 4, 2024 · 2 comments · Fixed by #16776
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@brandon-b-miller
Copy link
Contributor

I would like to use this datetime component enum in some kind of function with a signature like the following:

std::unique_ptr<column> extract_datetime_component(column_view const &column, datetime_component component) { }

This would help push a little messy logic in the cudf cython code down into libcudf and hopefully fits the pattern of the rest of libcudf. I am happy to take this on if this seems like an agreeable change 👍

@brandon-b-miller brandon-b-miller added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. labels Sep 4, 2024
@davidwendt
Copy link
Contributor

This sounds good to me. I would also like to consider removing the individual APIs in favor of this one if that make sense.

@bdice
Copy link
Contributor

bdice commented Sep 9, 2024

Should extract-with-enum accept multiple enum values (in a cudf::host_span), thereby allowing the extraction of multiple components into a cudf::table with a single kernel call?

That might help with some performance concerns we discussed in #16500 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants