Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA][JNI] Move to RMM apis get_current_device_resource_ref and set_current_device_resource_ref #16673

Open
abellina opened this issue Aug 27, 2024 · 1 comment
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS

Comments

@abellina
Copy link
Contributor

This change rapidsai/rmm#1661 deprecates the pointer based get_current_device_resource and set_current_device_resource in favor of a non-owning reference based set_current_device_resource_ref and get_current_device_resource_ref.

RMM JNI currently uses the pointer based apis so we want to move to the new _ref versions. I don't think we need to worry about ownership, because we already have a java object tracking a heap allocated memory resource.

@abellina abellina added feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS labels Aug 27, 2024
@harrism
Copy link
Member

harrism commented Aug 27, 2024

Thanks for the issue. #1661 does not deprecate anything yet. I'm still experimenting with minimizing how invasive the changes have to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
Status: To-do
Development

No branches or pull requests

2 participants