Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] from_arrow_device and from_arrow_host should take device_async_resource_ref, not device_memory_resource* #16159

Closed
harrism opened this issue Jul 2, 2024 · 0 comments · Fixed by #16160
Closed

[BUG] from_arrow_device and from_arrow_host should take device_async_resource_ref, not device_memory_resource* #16159

harrism opened this issue Jul 2, 2024 · 0 comments · Fixed by #16160
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@harrism
Copy link
Member

harrism commented Jul 2, 2024 •
edited
Loading

Describe the bug
#15458 added from_arrow_device but was merged after #15507 which replaced resource pointers with resource refs.
#15645 was opened after #15507 but also added resource pointer parameters in from_arrow_host.

Expected behavior
resource pointers should all be changed to resource refs.
@harrism harrism added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. labels Jul 2, 2024
@harrism harrism mentioned this issue Jul 2, 2024
Merged
3 tasks
@rapids-bot rapids-bot bot closed this as completed in 39de5a2 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor from_arrow_device/host to use resource_ref harrism/cudf
1 participant
@harrism