Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Respect set_output_as_binary in ORC writer #14375

Open
lidavidm opened this issue Nov 8, 2023 · 1 comment
Open

[FEA] Respect set_output_as_binary in ORC writer #14375

lidavidm opened this issue Nov 8, 2023 · 1 comment
Assignees
@vuule
Labels
0 - Backlog In queue waiting for assignment cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Milestone
ORC continuous im...

Comments

@lidavidm
Copy link

lidavidm commented Nov 8, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
The cuDF ORC writer does not follow the set_output_as_binary option added for Parquet to write a string column with binary type.

Describe the solution you'd like
To respect the set_output_as_binary option added in #6816 for the ORC writer as well.

Describe alternatives you've considered
We could copy the table to host and use the Arrow ORC writer or similar instead, but this would mean more copying.

Additional context
Quick demo using libcudf 23.10: https://github.com/lidavidm/cudf-orc-binary-feature-request
@lidavidm lidavidm added Needs Triage Need team to review and classify feature request New feature or request labels Nov 8, 2023
@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue and removed Needs Triage Need team to review and classify labels Dec 14, 2023
@GregoryKimball
Copy link
Contributor

@vuule Would you please take a peek at this issue?

@vuule vuule self-assigned this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuule vuule

Labels
0 - Backlog In queue waiting for assignment cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
libcudf
Status: No status
Milestone
ORC continuous improvement
Development

No branches or pull requests
3 participants
@lidavidm @GregoryKimball @vuule