Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require streams in public API for groupby aggregate. #13737

Closed
bdice opened this issue Jul 24, 2023 · 2 comments
Closed

Require streams in public API for groupby aggregate. #13737

bdice opened this issue Jul 24, 2023 · 2 comments
Labels
good first issue Good for newcomers
Milestone
Enable streams

Comments

@bdice
Copy link
Contributor

bdice commented Jul 24, 2023

In #13727, we added a public API accepting a stream while retaining the old overload that does not accept a stream. We are migrating to requiring streams in public APIs, so the old overload without a stream should be removed. We decided to accept this for 23.08 (during burndown) with the intent to fix in 23.10.

cc: @mythrocks @vyasr
@bdice bdice mentioned this issue Jul 24, 2023
Merged
3 tasks
@vyasr vyasr added this to the Enable streams milestone Jul 24, 2023
@vyasr
Copy link
Contributor

vyasr commented Jul 24, 2023

The title here sounds like a duplicate of #11463, but I think the work here is a subset of that (a single API, and just a removal of the old API).

@bdice bdice added the good first issue Good for newcomers label Nov 2, 2023
@ttnghia ttnghia mentioned this issue Nov 6, 2023
Merged
3 tasks
@karthikeyann karthikeyann mentioned this issue Dec 7, 2023
Open
@davidwendt
Copy link
Contributor

Closed by #17324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Enable streams
Development

No branches or pull requests
3 participants
@vyasr @bdice @davidwendt