Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support <4 byte types in GroupBy.apply with engine='jit' #13736

Open
brandon-b-miller opened this issue Jul 24, 2023 · 1 comment
Open
Labels
feature request New feature or request numba Numba issue

Comments

@brandon-b-miller
Copy link
Contributor

Is your feature request related to a problem? Please describe.
During #13729 we were able to round out the 4 and 8 byte dtypes supported by the groupby JIT engine, however shorter types such as int8 and int16 couldn't be added due to the missing support for those types from certain libcu++ features we rely on in the shim library.

Describe the solution you'd like
We should provide block level implementations for these types in c++ that don't rely on the particular libcu++ features.

Describe alternatives you've considered
We could also wait for libcu++ to provide things like atomic_ref for shorter types.

cc @bwyogatama @PointKernel

@PointKernel
Copy link
Member

Related to NVIDIA/cccl#1024

@vyasr vyasr removed the python label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request numba Numba issue
Projects
None yet
Development

No branches or pull requests

3 participants