Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Improve performance of mixed joins on H100 #13662

Closed
GregoryKimball opened this issue Jul 5, 2023 · 1 comment
Closed

[BUG] Improve performance of mixed joins on H100 #13662

GregoryKimball opened this issue Jul 5, 2023 · 1 comment
Labels
0 - Backlog In queue waiting for assignment bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue

Comments

@GregoryKimball
Copy link
Contributor

GregoryKimball commented Jul 5, 2023

When comparing x86-H100 versus x86-V100 microbenchmark performance in libcudf, we found that mixed join benchmarks showed slower runtimes on H100. The rest of libcudf microbenchmarks tend to be around 2-3x faster. Perhaps we need to adjust DEFAULT_JOIN_BLOCK_SIZE (code pointer), or some other performance hinting on the mixed join kernels.

Also see #10534 which added launch bounds to mixed joins kernels.

Figure showing H100 vs V100 speedup results:
image

Figure zooming in on JOIN benchmarks:
image

[Based on libcudf 23.08 commit aed7174eae6c6]

@GregoryKimball GregoryKimball added feature request New feature or request Needs Triage Need team to review and classify 0 - Backlog In queue waiting for assignment libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Jul 5, 2023
@GregoryKimball GregoryKimball moved this to Needs owner in libcudf Jul 5, 2023
@GregoryKimball GregoryKimball changed the title [FEA] Improve performance of mixed joins on H100 [BUG] Improve performance of mixed joins on H100 Jul 10, 2023
@GregoryKimball GregoryKimball added bug Something isn't working Performance Performance related issue and removed feature request New feature or request labels Jul 10, 2023
@GregoryKimball
Copy link
Contributor Author

GregoryKimball commented Aug 8, 2023

I reran the JOIN_NVBENCH benchmarks on V100, A100, H100 with 23.10 commit 9e099cef25b11. I could not reproduce the issue. I suspect the original observations were not using the same commit.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue
Projects
None yet
Development

No branches or pull requests

1 participant