Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrust_create_target dependency #13468

Closed
sononix opened this issue May 28, 2023 · 5 comments
Closed

thrust_create_target dependency #13468

sononix opened this issue May 28, 2023 · 5 comments
Labels
0 - Waiting on Author Waiting for author to respond to review question Further information is requested

Comments

@sononix
Copy link

sononix commented May 28, 2023

I'm trying to build the basic example on ubuntu 20.04 > cuda 11.8 and having trouble in getting the example to compile, I had it working on an older install be for some reason Im getting the following error

CMake Error at /usr/lib/cmake/cudf/cudf-config.cmake:178 (thrust_create_target): Unknown CMake command "thrust_create_target". Call Stack (most recent call first): build/cmake/CPM_0.35.3.cmake:216 (find_package) build/cmake/CPM_0.35.3.cmake:273 (cpm_find_package) CMakeLists.txt:23 (CPMFindPackage)

Ive tried adding the library in the command line using

cmake -S . -DThrust_DIR=/home/..../thrust/thrust/cmake -B build

and setting the dependence in the cmakefile but neither approaches seem to work

set(Thrust_DIR /home/..../thrust/thrust/cmake)

the full output to screen is

sudo cmake -S . -B build -- The CXX compiler identification is GNU 9.4.0 -- The CUDA compiler identification is NVIDIA 11.8.89 -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Detecting CUDA compiler ABI info -- Detecting CUDA compiler ABI info - done -- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc - skipped -- Detecting CUDA compile features -- Detecting CUDA compile features - done -- Downloading CPM.cmake to /home/ms/CODE/NVIDIA/cudf/cpp/examples/basic/build/cmake/CPM_0.35.3.cmake -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- Found CUDAToolkit: /usr/local/cuda/include (found version "11.8.89")

Ive managed to build cudf from source and thrust library from source on the box, but the thrust_create_target error has me stumped
Anyone any idea to what might be causing the error

tks

@sononix sononix added Needs Triage Need team to review and classify question Further information is requested labels May 28, 2023
@bdice
Copy link
Contributor

bdice commented May 30, 2023

@sononix Do you need to use a custom Thrust build? I don't think cuDF supports that since we have to patch Thrust:

https://github.com/rapidsai/cudf/blob/branch-23.08/cpp/cmake/thirdparty/patches/thrust_override.json

@robertmaynard Would you have thoughts on this?

@robertmaynard
Copy link
Contributor

We don't support an external Thrust due to the patches we apply.

@sononix
Copy link
Author

sononix commented May 30, 2023

My bad I was missing an argument in the build.sh file for the CMAKE_CUDA_COMPILER - though I'm getting blocked on the linking or ld not being able to locate nvToolsExt - it appears it is needed in the strings example and is blocking the build process

/usr/bin/ld: cannot find -lnvToolsExt collect2: error: ld returned 1 exit status gmake[2]: *** [CMakeFiles/libcudf_apis.dir/build.make:100: libcudf_apis] Error 1 gmake[1]: *** [CMakeFiles/Makefile2:89: CMakeFiles/libcudf_apis.dir/all] Error 2 gmake[1]: *** Waiting for unfinished jobs....

should it not be installed along with cuda?

@bdice
Copy link
Contributor

bdice commented Jun 14, 2023

@sononix Can you provide more information, or a minimal reproducer? What version are you building? I think we switched to the header-only form of nvtx in #13165 (and similar PRs elsewhere in RAPIDS), so I'm unsure what needs nvToolsExt libraries to be linked.

@GregoryKimball GregoryKimball added 0 - Waiting on Author Waiting for author to respond to review and removed Needs Triage Need team to review and classify labels Jun 26, 2023
@vyasr
Copy link
Contributor

vyasr commented May 15, 2024

Closing as stale. Feel free to reopen if needed.

@vyasr vyasr closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Waiting on Author Waiting for author to respond to review question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants