Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] chunked_pack should allow variable sized spans in the next call #13332

Open
abellina opened this issue May 10, 2023 · 1 comment
Open
Assignees
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@abellina
Copy link
Contributor

As brought up here #13260 (comment), chunked_pack requires that it be configured with a single size for the user's bounce buffer, and further requires the same size of device memory made available in every call to chunked_pack::next.

This is overkill in the case where we have actually very little work to be done (the source table is small). So the proposal is to allow for a get_next_size() api that lets us know the size of buffer that should be made available to next

@abellina abellina added feature request New feature or request Needs Triage Need team to review and classify Reliability labels May 10, 2023
@abellina abellina self-assigned this May 18, 2023
@abellina
Copy link
Contributor Author

Note that there was more feedback #13260 (review) that it would be good to tackle as a clean up PR separate from this particular issue.

@GregoryKimball GregoryKimball added libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS 0 - Backlog In queue waiting for assignment and removed Needs Triage Need team to review and classify labels Jun 7, 2023
@vyasr vyasr removed the Reliability label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

No branches or pull requests

3 participants